Skip to content

Add HTTP resilience mode #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Add HTTP resilience mode #176

merged 4 commits into from
May 21, 2025

Conversation

jessemortenson
Copy link
Contributor

This is a WIP draft of porting the HTTP resilience features that @elseagle introduced (originally in the FL scraper, later I re-used in IA scraper) up into openstates-core. The goal is to turn these features into a toggleable behavior instead of something that needs to be grafted onto scrapers one-by-one.

This is not sufficiently tested yet. I'm running an IA scrape (with the grafted version removed from scraper code), and will want to do the same with FL. And then test with some other scrapers to make sure I haven't regressed something.

cc @showerst and @alexobaseki

Copy link
Contributor

@alexobaseki alexobaseki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jessemortenson jessemortenson marked this pull request as ready for review May 20, 2025 22:56
@jessemortenson
Copy link
Contributor Author

jessemortenson commented May 20, 2025

I have this working offline with PA and IA, both with the similar logic removed from the specific scrapers. So I think this is ready to merge.

@showerst - is your team running a setup where you are comfortable keeping scrapers at an earlier version? I'm guessing yes but wanted to double check. Obviously I'll want to merge this in, but also make a follow-up merge in openstates-scrapers to de-patch PA and IA (openstates/openstates-scrapers#5392)

(Edit: forgot that FL is spatula-based ... I'm not going to patch this stuff upstream in spatula... so forget FL)

It's not urgent, so if it's more comfortable for me to wait a week or something that's no problem.

@showerst
Copy link
Contributor

Yeah i'm on a fork for where we can pick and choose -- feel free to merge all the changes you need in both projects and we'll get caught up when we're ready. Thanks for the H/U.

@jessemortenson jessemortenson merged commit 68e8b5c into main May 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants